-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #137 add nuxt img integration resulting in modern image and responsive sizes by default, improves performance (mobile). #146
base: main
Are you sure you want to change the base?
Conversation
… formats and responsive sizes by default, improves performance (mobile).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…tyling to work
Hey, all the images are broken on the latest deployment. Is this expected? Can I help in fixing this somehow? |
Hi! Yes, they are. This is not expected and I'm not sure how to resolve the issue. Please see #137 (comment). |
8afada1
to
5b20d50
Compare
5b20d50
to
8afada1
Compare
@Tahul I've updated Nuxt to 3.6.0 because of nuxt/image#638 and nuxt/nuxt#21655 which may solve the problem of images being broken. The deployment is failing, I do not know why, sadly that blocks me from checking the validity of this fix. I'd appreciate your help. |
749b001
to
e9d6b67
Compare
The latest deploy seems to have worked. What I see is that all of the URL's that reference images are being manipulated by Vercel. The HTML generated is correct (using the fetchpriorities, decoding, native lazy loading and webp with fallback to png). The differences between Vercel deploy and Netlify deploy: <picture fetchpriority="high">
<source type="image/webp"
sizes="(max-width: 320px) 320px, (max-width: 640px) 640px, (max-width: 768px) 768px, (max-width: 1024px) 1024px, (max-width: 1280px) 1280px, (max-width: 1536px) 1536px, 1536px"
srcset="/_vercel/image?url=/alpine-0.webp&w=320&q=100 320w, /_vercel/image?url=/alpine-0.webp&w=640&q=100 640w, /_vercel/image?url=/alpine-0.webp&w=768&q=100 768w, /_vercel/image?url=/alpine-0.webp&w=1024&q=100 1024w, /_vercel/image?url=/alpine-0.webp&w=1280&q=100 1280w, /_vercel/image?url=/alpine-0.webp&w=1536&q=100 1536w, /_vercel/image?url=/alpine-0.webp&w=1536&q=100 1536w">
<img alt="Hero Image" loading="eager" decoding="sync" onerror="this.setAttribute('data-error', 1)" class="right"
data-nuxt-pic="" src="/_vercel/image?url=/alpine-0.webp&w=1536&q=100"
sizes="(max-width: 320px) 320px, (max-width: 640px) 640px, (max-width: 768px) 768px, (max-width: 1024px) 1024px, (max-width: 1280px) 1280px, (max-width: 1536px) 1536px, 1536px"
srcset="/_vercel/image?url=/alpine-0.webp&w=320&q=100 320w, /_vercel/image?url=/alpine-0.webp&w=640&q=100 640w, /_vercel/image?url=/alpine-0.webp&w=768&q=100 768w, /_vercel/image?url=/alpine-0.webp&w=1024&q=100 1024w, /_vercel/image?url=/alpine-0.webp&w=1280&q=100 1280w, /_vercel/image?url=/alpine-0.webp&w=1536&q=100 1536w, /_vercel/image?url=/alpine-0.webp&w=1536&q=100 1536w"
data-error="1" width="432" height="288">
</picture> <picture fetchpriority="high">
<source type="image/webp"
sizes="(max-width: 320px) 320px, (max-width: 640px) 640px, (max-width: 768px) 768px, (max-width: 1024px) 1024px, (max-width: 1280px) 1280px, (max-width: 1536px) 1536px, 1536px"
srcset="/_ipx/f_webp&s_320x213/alpine-0.webp 320w, /_ipx/f_webp&s_640x427/alpine-0.webp 640w, /_ipx/f_webp&s_768x512/alpine-0.webp 768w, /_ipx/f_webp&s_1024x683/alpine-0.webp 1024w, /_ipx/f_webp&s_1280x853/alpine-0.webp 1280w, /_ipx/f_webp&s_1536x1024/alpine-0.webp 1536w, /_ipx/f_webp&s_1536x1024/alpine-0.webp 1536w">
<img alt="Hero Image" loading="eager" decoding="sync" onerror="this.setAttribute('data-error', 1)" class="right"
data-nuxt-pic="" src="/_ipx/f_png&s_1536x1024/alpine-0.webp"
sizes="(max-width: 320px) 320px, (max-width: 640px) 640px, (max-width: 768px) 768px, (max-width: 1024px) 1024px, (max-width: 1280px) 1280px, (max-width: 1536px) 1536px, 1536px"
srcset="/_ipx/f_png&s_320x213/alpine-0.webp 320w, /_ipx/f_png&s_640x427/alpine-0.webp 640w, /_ipx/f_png&s_768x512/alpine-0.webp 768w, /_ipx/f_png&s_1024x683/alpine-0.webp 1024w, /_ipx/f_png&s_1280x853/alpine-0.webp 1280w, /_ipx/f_png&s_1536x1024/alpine-0.webp 1536w, /_ipx/f_png&s_1536x1024/alpine-0.webp 1536w"
width="432" height="288">
</picture> Could it be a configuration in Vercel that is breaking the images? |
No description provided.