Skip to content

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Oct 4, 2021

Merge @HarryR's PR to remove the use of exceptions in domain selection logic: scipr-lab/libfqfft#12
Original branch: https://github.com/Ethsnarks/libfqfft/tree/no-exceptional-control-flow

@dtebbs dtebbs changed the title [WIP] Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #3) [WIP] Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6) Oct 11, 2021
@dtebbs
Copy link
Contributor Author

dtebbs commented Oct 11, 2021

Relies on clearmatics/libff#64

@dtebbs dtebbs changed the title [WIP] Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6) Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6) Oct 11, 2021
@dtebbs dtebbs marked this pull request as ready for review October 11, 2021 11:52
@AntoineRondelet AntoineRondelet changed the base branch from build-fixes to master October 13, 2021 11:58
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoineRondelet AntoineRondelet merged commit 620cef1 into master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants