Raise Error::CookieError more often #67
Merged
+86
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a LEETCODE_SESSION becomes invalid
…entication, use `is_session_bad()` to check if LEETCODE_SESSION is valid.
|
Great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #55 #57 (not #60, that is unaddressed in this PR)
Previously:
Now:
$ cargo run t 1 Finished dev [unoptimized + debuginfo] target(s) in 0.06s Running `target/debug/leetcode t 1` [INFO leetcode_cli::plugins::leetcode] Sending code to judge... error: Your leetcode cookies seems expired, please make sure you have logined in leetcode.com with chrome. Either you can handwrite your `LEETCODE_SESSION` and `csrf` into `leetcode.toml`, more info please checkout this: https://github.com/clearloop/leetcode-cli/blob/master/README.md#cookiesI have introduced a general method,
is_session_bad(), which should reliably answer the question of, "isLEETCODE_SESSIONinvalid?". Emphasis on should, because I have attached no additional tests in this PR as well.Some of the code added is not very good. Please edit/criqitue as you see fit.