Fix Bug in qinit in advection_2d_inflow Example#311
Merged
Conversation
Member
Author
|
@mjberger this fixes the problem you were seeing, and I think the cause is now narrowed to implicit typing giving |
mjberger
approved these changes
Oct 31, 2025
Contributor
mjberger
left a comment
mjberger
left a comment
There was a problem hiding this comment.
looks good. that's the way I fixed it too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there was not
implicit noneinqinitthe variablesxiandyjwere defaulting to single precision and somehow getting misinterpreted when relying on an external call toqtrue. This currently add explicit declarations ofxiandyjto fix this. Declaring the interface toqtruealso gives an error due to type mismatch. Full fix includes animplicit noneand explicit typing for all variables and the functionqtrue.