Skip to content

New pytest test runner#310

Merged
rjleveque merged 23 commits into
clawpack:masterfrom
mandli:new-pytest-test-runner
Apr 4, 2026
Merged

New pytest test runner#310
rjleveque merged 23 commits into
clawpack:masterfrom
mandli:new-pytest-test-runner

Conversation

@mandli
Copy link
Copy Markdown
Member

@mandli mandli commented Sep 15, 2025

Uses the new ClawpackTestRunner to do testing. See clawpack/clawutil#187 for discussion and details.

@mandli mandli marked this pull request as draft September 15, 2025 16:03
@mandli mandli marked this pull request as ready for review March 16, 2026 18:08
@mandli mandli force-pushed the new-pytest-test-runner branch from 63c061f to 0d9fb1a Compare March 16, 2026 20:44
mandli added 12 commits March 16, 2026 16:52
This also required updating of the regression data as one of the gauges
ended up having an extra time point due to unrelated changes.  All
differences were around 10^-16.
Requires a new argument to test runner build_executable to allow make
variables in the command
This is an attempt to support adjoint testing without redoing each adjoint
run twice and providing more stability and less fragility.  A new helper
function has been added to the AMRClaw test python module.  Hopefully this
will also work in GeoClaw.
@mandli mandli force-pushed the new-pytest-test-runner branch from 0d9fb1a to c2a9245 Compare March 16, 2026 21:00
@mandli
Copy link
Copy Markdown
Member Author

mandli commented Mar 16, 2026

Turns out that some of the optimization flags are more sensitive that I had thought. All the tests are passing in the entire matrix now though! Note that for optimization flags that something more aggressive than -O1 may not work.

@mjberger
Copy link
Copy Markdown
Contributor

mjberger commented Mar 17, 2026 via email

@mandli
Copy link
Copy Markdown
Member Author

mandli commented Mar 17, 2026

Yes, the tests themselves are susceptible to this, but in general this is not an issue. The adjoint tests seem to be the most sensitive, but the acoustics 2D radial problem also seems to have issues.

@rjleveque
Copy link
Copy Markdown
Member

@mandli: good to know, thanks for tracking this down!

@mandli
Copy link
Copy Markdown
Member Author

mandli commented Apr 2, 2026

I think I am close to working out all the issues with the new testing framework, but still working on getting test result archiving and a couple of other bugs working. Things that I probably won't get to, but can get added later:

  1. Additional test suites, such as slow, or plotting. Right now there's just regression, and a couple of tests are marked as slow or adjoint to help default testing.
  2. All the AMRClaw tests pass, but there are some places we could extend coverage.
  3. Additional things in GeoClaw, but I will detail that in Switch to Using ClawpackTestRunner for Testing geoclaw#697

@rjleveque
Copy link
Copy Markdown
Member

Merging this along with clawpack/classic#96 and clawpack/geoclaw#697, which has some additional details on tests.

@rjleveque rjleveque merged commit 61e444c into clawpack:master Apr 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants