parallelizing file existance check using promises#188
Open
maxlath wants to merge 2 commits intoclaudioc:masterfrom
Open
parallelizing file existance check using promises#188maxlath wants to merge 2 commits intoclaudioc:masterfrom
maxlath wants to merge 2 commits intoclaudioc:masterfrom
Conversation
Owner
|
This is very good point. I like how this PR works and I definitely would like to merge it. I propose that you try to kill all the What do you think? Thanks! |
Contributor
Author
|
4d5495f focuses on killing all uses of |
Contributor
Author
|
Then, getting those to work async seems to require some heavy rewriting. That could make sense in an effort to get the whole project into promises flow but I can't give it the time in needs unfortunately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations:
fs.existsis deprecated since NodeJS v1.0.0If this sounds like good motivations, I can have a look at other places where
fs.existsSyncis used throughout the project :)thanks for this great project!