Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eslint package collision #815

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

harsh183
Copy link
Member

@harsh183 harsh183 commented Jun 8, 2024

This was showing up as a build warning because I think we had our own eslint versions as well as the ones CRA liked. I picked the later one in each case and moved it all to dev dependencies.

@harsh183 harsh183 requested a review from angrave June 8, 2024 00:30
@angrave
Copy link
Collaborator

angrave commented Jun 8, 2024

Nice. (The next time you touch the package versions if would be great to update the a11y checkers to their latest versions.)

Copy link
Collaborator

@angrave angrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging

@angrave angrave merged commit b79bcc0 into staging Jun 8, 2024
2 checks passed
@angrave angrave deleted the hd/fix-eslint-package-collision branch June 8, 2024 00:39
@harsh183
Copy link
Member Author

harsh183 commented Jun 8, 2024

#821 - added this for bumping a11y linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants