Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Instructor List Admin Page formatting to check lastName before outputting unknown (Closes #808) #809

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

harsh183
Copy link
Member

@harsh183 harsh183 commented Jun 2, 2024

Added a few format function to clean this up

@harsh183 harsh183 requested a review from angrave June 2, 2024 04:18
Copy link
Collaborator

@angrave angrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angrave
Copy link
Collaborator

angrave commented Jun 2, 2024

src/screens/Admin/Instructors/InstructorList.jsx
Line 35:12: Unnecessary 'else' after 'return' no-else-return

@angrave angrave merged commit 6e3ffcb into staging Jun 2, 2024
2 checks passed
@angrave angrave deleted the hd/improve-admin-instructor-list-name-formatting branch June 2, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants