Remove jQuery from Instructor List (Fix #777 Part 1/2) #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
harsh183
commented
Jun 2, 2024
| @@ -1,4 +1,4 @@ | |||
| import { render, screen, fireEvent } from '@testing-library/react'; | |||
There was a problem hiding this comment.
Just code cleanup on this file, nothing new
harsh183
commented
Jun 2, 2024
| @@ -15,7 +15,7 @@ export default function InstructorList({ instructors, loading, currUni, onInacti | |||
| const onSearch = (keyCode) => { | |||
There was a problem hiding this comment.
@angrave if we want, we can make the search happen 'live' with every state change. That way we won't need to even hit enter or click the button now that we're not using jQuery
There was a problem hiding this comment.
This can be a separate commit actually, I'll make this into a new issue so that this PR is fixed on just removing jquery.
There was a problem hiding this comment.
Sounds good.
@harsh183
FYI how to properly debounce a search in react-
https://www.alexhughes.dev/blog/settimeout-with-hooks/
https://dev.to/imforja/5-steps-to-perform-a-search-when-user-stops-typing-using-react-hooks-in-a-controlled-component-5edd
angrave
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Instructor List we can replace $ find with a react state. I added test cases with a new library
@testing-library/user-eventto make sure we preserve the existing functionality of the view.