Fill the Currrency Field without checking (#128)

* No Need to check if currency field exists the currency field might not exist (initialized) yet, so it doesn't fill the currency field when a new instance is created * add a test for filling currencies add check if the field is a currency or an attribute * fix style issues * Update MoneyCastTest.php Co-authored-by: Ahmed Ghorab <[email protected]>
cknow · Nov 9, 2022 · 8c3ed1c · 8c3ed1c
1 parent 13a87ac
commit 8c3ed1c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Casts/MoneyCast.php b/src/Casts/MoneyCast.php
@@ -89,7 +89,7 @@ public function set($model, string $key, $value, array $attributes)
 
         $amount = $this->getFormatter($money);
 
-        if (array_key_exists($this->currency, $attributes)) {
+        if ($this->currency && ! Money::isValidCurrency($this->currency)) {
             return [$key => $amount, $this->currency => $money->getCurrency()->getCode()];
         }
 

diff --git a/tests/MoneyCastTest.php b/tests/MoneyCastTest.php
@@ -151,4 +151,15 @@ public function testFailsToParseInvalidMoney()
 
         new User(['money' => 'abc']);
     }
+
+    public function testSetCurrencyForNewEmptyUser()
+    {
+        $user = new User();
+
+        $user->debits = 100.99;
+
+        static::assertSame('10099', $user->debits->getAmount());
+        static::assertSame('USD', $user->debits->getCurrency()->getCode());
+        static::assertSame('USD', $user->currency);
+    }
 }