This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Refactor check_pending() and retry Jenkins completion check #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for rechecking baselines is no longer needed. Fixes cki-project#106. Signed-off-by: Major Hayden <[email protected]>
Rename variables so they are easier to read and understand. Signed-off-by: Major Hayden <[email protected]>
Ensure that a temporary network hiccup will not cause sktm to mark an entire test as failed. If a build completion check fails, retry the check during the next loop. Signed-off-by: Major Hayden <[email protected]>
Signed-off-by: Major Hayden <[email protected]>
Add comments, remove the if/elif/else, and create the `patches` variable using dictionary comprehension. Signed-off-by: Major Hayden <[email protected]>
Pull Request Test Coverage Report for Build 375
💛 - Coveralls |
Contributor
|
@major, should we still work on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
check_pending(), improves readability, and wraps the completion check intry/except. It also includes a removal of the baseline checking logic.Fixes #106.