Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes delete and update showcase buttons #173

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

MarkCalvert
Copy link
Contributor

Currently, c.form_action and c.form_style do not return anything.
This means that the logic for displaying the delete and update buttons will not work.
Refactored code to avoid using c. to assign action and form_style variables.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…x showing delete and update showcase buttons
@bellisk
Copy link
Contributor

bellisk commented Jan 29, 2025

The failing test action is only for CKAN 2.9, and we just dropped testing against version in #174 so there's no reason not to merge this. :)

@bellisk bellisk merged commit 52fe2d4 into ckan:master Jan 29, 2025
3 of 4 checks passed
@bellisk
Copy link
Contributor

bellisk commented Jan 29, 2025

Included in v1.8.1, thanks a lot @MarkCalvert

MarkCalvert added a commit to dbca-wa/ckan-docker that referenced this pull request Feb 11, 2025
…uting PR was merged ckan/ckanext-showcase#173

Cleaned up file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants