execute() - Declare explicit return type

This is strictly necessary for Symfony 5. However, the actual beahvior
in S5 is the throw an error if you don't return `int`.  So we might
as well get the IDE to give hints about this.

src/Command/AngularHtmlListCommand.php

@@ -37,7 +37,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     if (!$input->getOption('user')) {
       $output->getErrorOutput()->writeln("<comment>For a full list, try passing --user=[username].</comment>");

src/Command/AngularHtmlShowCommand.php

@@ -41,7 +41,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     if (!$input->getOption('user')) {
       $output->getErrorOutput()->writeln("<comment>For a full list, try passing --user=[username].</comment>");

src/Command/AngularModuleListCommand.php

@@ -39,7 +39,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     if (!$input->getOption('user')) {
       $output->getErrorOutput()->writeln("<comment>For a full list, try passing --user=[username].</comment>");

src/Command/Api4Command.php

@@ -125,7 +125,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $C = '<comment>';
     $_C = '</comment>';
     $I = '<info>';

src/Command/ApiCommand.php

@@ -50,7 +50,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $C = '<comment>';
     $_C = '</comment>';
     $I = '<info>';

src/Command/CoreCheckReqCommand.php

@@ -38,7 +38,7 @@ protected function configure() {
     $this->configureBootOptions('none');
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $filterSeverities = $this->parseFilter($input);
 
     $showBootMsgsByDefault = in_array($input->getOption('out'), ['table', 'pretty']);

src/Command/EditCommand.php

@@ -46,7 +46,7 @@ public function __construct($name = NULL) {
     });
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
 
     $config = Config::read();

src/Command/EvalCommand.php

@@ -40,7 +40,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
 
     if ($input->getOption('out') === 'auto') {

src/Command/ExtensionDisableCommand.php

@@ -37,7 +37,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     list ($foundKeys, $missingKeys) = $this->parseKeys($input, $output);
 

src/Command/ExtensionDownloadCommand.php

@@ -68,7 +68,7 @@ protected function initialize(InputInterface $input, OutputInterface $output) {
     parent::initialize($input, $output);
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $fs = new Filesystem();
 
     if ($extRepoUrl = $this->parseRepoUrl($input)) {

src/Command/ExtensionEnableCommand.php

@@ -40,7 +40,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
 
     // Refresh extensions if (a) ---refresh enabled or (b) there's a cache-miss.

src/Command/ExtensionListCommand.php

@@ -49,7 +49,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $wo = ($input->getOption('out') === 'table')
       ? (OutputInterface::OUTPUT_NORMAL | OutputInterface::VERBOSITY_NORMAL)
       : (OutputInterface::OUTPUT_NORMAL | OutputInterface::VERBOSITY_VERBOSE);

src/Command/ExtensionUninstallCommand.php

@@ -37,7 +37,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     list ($foundKeys, $missingKeys) = $this->parseKeys($input, $output);
 

src/Command/FlushCommand.php

@@ -22,7 +22,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     // The main reason we have this as separate command -- so we can ignore
     // stale class-references that might be retained by the container cache.
     define('CIVICRM_CONTAINER_CACHE', 'never');

src/Command/PathCommand.php

@@ -58,7 +58,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
 
     if (!$input->getOption('ext') && !$input->getOption('config') && !$input->getOption('dynamic')) {

src/Command/PipeCommand.php

@@ -50,7 +50,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     if (!is_callable(['Civi', 'pipe'])) {
       fwrite(STDERR, "This version of CiviCRM does not include Civi::pipe() support.\n");

src/Command/ScriptCommand.php

@@ -21,7 +21,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $fs = new Filesystem();
     $origScript = $fs->toAbsolutePath($input->getArgument('script'));
     $scriptArguments = $input->getArgument('scriptArguments');

src/Command/SettingGetCommand.php

@@ -71,7 +71,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
 
     $filter = $this->createSettingFilter($input->getArgument('name'));

src/Command/SettingRevertCommand.php

@@ -62,7 +62,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
     $errorOutput = is_callable([$output, 'getErrorOutput']) ? $output->getErrorOutput() : $output;
 

src/Command/SettingSetCommand.php

@@ -85,7 +85,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $C = '<comment>';
     $_C = '</comment>';
     $I = '<info>';

src/Command/SqlCliCommand.php

@@ -47,7 +47,7 @@ protected function initialize(InputInterface $input, OutputInterface $output) {
     }
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $this->boot($input, $output);
 
     $datasource = new Datasource();

src/Command/UpgradeCommand.php

@@ -24,7 +24,7 @@ protected function configure() {
     // parent::configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
 
     throw new \RuntimeException("FIXME: Calls to run() should be escaped, e.g. with Process::sprintf()");
 

src/Command/UpgradeGetCommand.php

@@ -42,7 +42,7 @@ protected function configure() {
     $this->configureBootOptions();
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     $result = array();
     $exitCode = 0;
     $stability = $input->getOption('stability');

src/Command/UrlCommand.php

@@ -76,7 +76,7 @@ protected function initialize(InputInterface $input, OutputInterface $output) {
     }
   }
 
-  protected function execute(InputInterface $input, OutputInterface $output) {
+  protected function execute(InputInterface $input, OutputInterface $output): int {
     if (in_array($input->getOption('out'), Encoder::getTabularFormats())
     && !in_array($input->getOption('out'), Encoder::getFormats())) {
       $input->setOption('tabular', TRUE);