Remove redundant custom field handling in contact import #32265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove redundant custom field handling in contact import
Before
The doc block on the function says this code does nothing & should be removed. We have pretty good code test cover and also the other imports rely on the
getMappedRow()
to format the custom fields without this & have their own testsI stepped through the code to check that this formatting was not doing anything & also ran a test to compare before & after - which only showed location formatting changes (as per the doc block) #32251
After
code gone
Technical Details
Comments