(WIP) Experiment - Separate auto_increment values for tests #32264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Entities created by tests usually have small ids starting at 1. Code or tests may muddle the identities and still pass. For example, see #32258 The code looks up ParticipantPayment records and then uses the ids of those records to update Participants instead of using Participant ids. There is a test but it passes because both the ParticipantPayment and Participant entities have id=1.
This change creates separation between the test entity values by changing the AUTO_INCREMENT value of tables.
Before
Some tests pass but should not.
After
Probably more failures ...
Technical Details
It only changes tables that still have AUTO_INCREMENT set to 1 after data is loaded. Might be worth extending to others.
Comments
Anything else you would like the reviewer to note