Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Experiment - Separate auto_increment values for tests #32264

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Feb 28, 2025

Overview

Entities created by tests usually have small ids starting at 1. Code or tests may muddle the identities and still pass. For example, see #32258 The code looks up ParticipantPayment records and then uses the ids of those records to update Participants instead of using Participant ids. There is a test but it passes because both the ParticipantPayment and Participant entities have id=1.

This change creates separation between the test entity values by changing the AUTO_INCREMENT value of tables.

Before

Some tests pass but should not.

After

Probably more failures ...

Technical Details

It only changes tables that still have AUTO_INCREMENT set to 1 after data is loaded. Might be worth extending to others.

Comments

Anything else you would like the reviewer to note

Copy link

civibot bot commented Feb 28, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 28, 2025
@colemanw
Copy link
Member

I really like this! We do have a few dumb tests in our suite that feel they're entitled to the number 1, but they look fixable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants