[REF] Faster pseudoconstant name lookups

[MegaphoneJon]

Overview

Profiling shows that we spend an inordinate amount of time converting pseudoconstant IDs into names. This is a performance fix.

Before

Slow.

After

Fast.

Comments

A few things going on here:

• This function is called a LOT, so even small differences will be magnified.
• We're calling the expensive function once, not once per value (in multivalued fields).
• There's a comment that says that CRM_Core_PseudoConstant::getlabel() is a cached function - but that's not necessarily true in places where the BAO overrides buildOptions().
• buildOptions is deprecated, so we remove calls to it.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

It's true that CRM_Core_DAO::buildOptions is annotated as @deprecated, but there are a couple slight differences which maybe we don't want to deal with in this legacy search function. One of them is handling for non-core fields added via fields_callback, which we've re-added support for:

civicrm-core/CRM/Core/DAO.php

Lines 2943 to 2946 in 8f164fe

	// Legacy handling for hook-based fields from `fields_callback`
	if (!$entity->getField($fieldName)) {
	return CRM_Core_PseudoConstant::get(static::class, $legacyFieldName, [], $context);
	}