Call Membership BAO::create directly instead of API3. This bypasses some duplicate functions and stops passing in ids[membership] #32257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome duplicate functions and stops passing in ids[membership]
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
mattwire
commented
Feb 28, 2025
| @@ -4078,20 +4078,20 @@ public static function updateMembershipBasedOnCompletionOfContribution($contribu | |||
| // We might be renewing membership so make status override false. | |||
| $membershipParams['is_override'] = FALSE; | |||
| $membershipParams['status_override_end_date'] = 'null'; | |||
| $membership = civicrm_api3('Membership', 'create', $membershipParams); | |||
| $membership = $membership['values'][$membership['id']]; | |||
| $membershipBAO = CRM_Member_BAO_Membership::create($membershipParams); | |||
There was a problem hiding this comment.
@[eileenmcnaughton] Can we use writeRecord() or apiv4 - I'm trying NOT to call the create() functions directly
Member
Author
@mattwire mattwire yesterday
Ideally yes... but writeRecord() bypasses all the logic in create which would be nice but requires a lot more rework. Calling via api3 forces the dreaded $ids['membership'] param to be passed in to create so I thought bypassing api3 initially would allow us to resolve that.
But depending on how much testing we have around this maybe we could actually unwrap all that and go to API4/writeRecord()
Member
@eileenmcnaughton eileenmcnaughton yesterday
what about apiv4?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Towards not passing
$ids['membership']intoCRM_Member_BAO_Membership::create()Before
API3 always passes in $ids
After
Not using API3 so not passed in.
Technical Details
Comments
Was part of #32222