Fix another Financial Type ACL bug

[MegaphoneJon]

Overview

While writing a test for #32189, I found two issues:

• My last change reintroduced the bug I was trying to solve, but only in some scenarios, because getAvailableFinancialTypes() gets a value passed by reference AND returns a value.
• The expected behavior for adding and removing ACLs without clearing cache is different.

Before

Sometimes, permissions for financial types with mismatched names/labels are incorrect.

After

Fixed.

Comments

This became much more complicated because the test seems to suggest that removing financial ACL permissions should have an immediate effect, even if adding financial ACL permissions requires a cache clear. Does that make sense? I don't know. But I had to jump through some hoops to maintain the original behavior.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[MegaphoneJon]

The test results are all over the place, I'm going to assume something is going on with the infra and I'll wait to retest this.

[seamuslee001]

Jenkins re test this please

[seamuslee001]

@MegaphoneJon do you think we need to include anything in the release notes because I imagine that for those that have granted financial type ACLs they may need to re-set them because the permission key has changed right?

[demeritcowboy]

I don't use financial acls anywhere, but this seems ok. That's so strange how it takes a seed list parameter and updates it but then also returns a list.

While your heads are in name/label/financial space don't suppose anyone wants to look at #32085? It's the same as 32084 (merged) just in a different spot.

Separately while looking at this I did find yet a few other places still using name instead of label. TBD.

[MegaphoneJon]

@MegaphoneJon do you think we need to include anything in the release notes because I imagine that for those that have granted financial type ACLs they may need to re-set them because the permission key has changed right?

@seamuslee001 no. The permission always used name, which is correct. The problem is getAvailableFinancialTypes was comparing the labels in civicrm_financial_type to the name of the permission.