Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CiviGrant PDF Letters #30321

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CiviGrant PDF Letters #30321

wants to merge 3 commits into from

Conversation

MegaphoneJon
Copy link
Contributor

Overview

Adds an option to print/merge documents when searching on grants.

Before

No option.

After

Option.

Comments

Grants don't have tokens natively defined, but they can be defined in an extension, and you can use SearchKit Tokens to easily add all the core grant tokens.

@civibot civibot
Copy link

civibot bot commented Jun 4, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jun 4, 2024
@colemanw
Copy link
Member

colemanw commented Jun 4, 2024

Why not.

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Jun 4, 2024
@MegaphoneJon MegaphoneJon changed the title CiviGrant PDF Letters [WIP] CiviGrant PDF Letters Jun 4, 2024
@MegaphoneJon MegaphoneJon removed the merge ready PR will be merged after a few days if there are no objections label Jun 4, 2024
@MegaphoneJon
Copy link
Contributor Author

I'm going to hold on this to make it SearchKit compatible. But I've actually had two groups ask me for batch grant agreement letters recently.

@MegaphoneJon MegaphoneJon mentioned this pull request Jun 4, 2024
Merged
@MegaphoneJon MegaphoneJon force-pushed the grant-pdf-letter branch 2 times, most recently from 91b28f0 to d27e56e Compare June 4, 2024 22:55
colemanw
colemanw reviewed Jun 5, 2024
View reviewed changes
CRM/Core/Task.php Outdated
@@ -153,15 +153,15 @@ public static function corePermissionedTaskTitles($tasks, $permission, $params)
* the set of tasks for a group of participants
*/
public static function getTask($value) {
static::tasks();
$tasks = static::tasks();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this function will also need to reset the self::tasks() variable?

@eileenmcnaughton
Copy link
Contributor

@MegaphoneJon out of interest have you had any requests for import grant functionality? I'm thinking of adding it - not because I actually care about importing grants but I wanted to try adding a 'generic' import so grants seemed like a good focus. We currently have the csv exporter but that uses apiv3 + it doesn't allow you to add an entity + contact in the same import

@MegaphoneJon MegaphoneJon force-pushed the grant-pdf-letter branch 2 times, most recently from b90fca9 to 9739656 Compare June 5, 2024 21:05
@MegaphoneJon MegaphoneJon changed the title [WIP] CiviGrant PDF Letters CiviGrant PDF Letters Jun 10, 2024
@eileenmcnaughton
Copy link
Contributor

@MegaphoneJon as a tangent on this I have opened #30461 which makes grants tokens available in core - although the intention is only partly about the grant tokens with the meta-goal being making it easy to add tokens to any entity via metadata rather than code

@MegaphoneJon
Copy link
Contributor Author

test this please

1 similar comment
@MegaphoneJon
Copy link
Contributor Author

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MegaphoneJon @colemanw @eileenmcnaughton