Repository navigation
Backport #8935: Parallelize cluster node health checks (release-13.2) - #8938
Merged
Volkan Cetin (vlkncetin) merged 3 commits intoOct 20, 2026
Merged
Conversation
(cherry picked from commit fadced9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cancellation test has a synchronization race that can cause nondeterministic failures.
1 open issue
What changed in this PR
Backports parallel cluster health checks to release-13.2, reducing probe latency while preserving result ordering.
Changes:
- Establish source connections and run checks concurrently.
- Preserve source-major output using a result matrix.
- Add concurrency and cancellation regression tests.
| File | Description |
|---|---|
| src/test/regress/citus_tests/test/test_cluster_node_health.py | Tests concurrent probes, results, and cancellation cleanup. |
| src/backend/distributed/operations/health_check.c | Parallelizes connectivity checks while preserving output order. |
Review effort: Balanced
Refactor checks_are_in_flight to include connection count check. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Emel Şimşek (emelsimsek)
approved these changes
Oct 20, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (29.15%) is below the target coverage (87.50%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## release-13.2 #8938 +/- ##
=================================================
- Coverage 88.72% 29.15% -59.57%
=================================================
Files 289 289
Lines 64641 64335 -306
Branches 8153 8063 -90
=================================================
- Hits 57351 18758 -38593
- Misses 4874 43383 +38509
+ Partials 2416 2194 -222 🚀 New features to boost your workflow:
|
Volkan Cetin (vlkncetin)
merged commit Oct 20, 2026
27446f8
into
release-13.2
498 of 599 checks passed
ibrahim halatci (ihalatci)
pushed a commit
that referenced
this pull request
Oct 21, 2026
ibrahim halatci (ihalatci)
pushed a commit
that referenced
this pull request
Oct 21, 2026
…#8939) Backports #8935 to release-14.0. - Parallelizes source connections and connectivity probes across source nodes. - Preserves result ordering and true/false/NULL semantics. - Includes the cancellation-test synchronization correction from the release-13.2 backport (#8938). Production code matches #8935; both changed files match #8938. Co-authored-by: Volkan Cetin <volkanetin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #8935 (fadced9).
Applies the merged implementation and regression tests unchanged.