Repository navigation
Backport #8935: Parallelize cluster node health checks (release-12.1) - #8937
Merged
Volkan Cetin (vlkncetin) merged 1 commit intoOct 20, 2026
Merged
Conversation
Adapt list iteration to release-12.1 foreach_ptr; retain the merged concurrency and cancellation regression coverage. (cherry picked from commit fadced9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Emel Şimşek (emelsimsek)
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cancellation test has a synchronization race that can cause intermittent assertion failures.
1 open issue
What changed in this PR
Backports parallel cluster health checks to release-12.1 while preserving result ordering and connectivity semantics.
Changes:
- Establishes source connections concurrently and runs probes in parallel across sources.
- Adapts loops to release-12.1’s
foreach_ptrmacro. - Adds concurrency and cancellation regression tests.
| File | Description |
|---|---|
| src/test/regress/citus_tests/test/test_cluster_node_health.py | Tests parallel probes, results, and cancellation. |
| src/backend/distributed/operations/health_check.c | Parallelizes connectivity checks while retaining source-major output. |
Review effort: Balanced
| def cancel_when_checks_are_in_flight(): | ||
| try: | ||
| deadline = time.monotonic() + 30 | ||
| while not checks_are_in_flight(): |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-12.1 #8937 +/- ##
==============================================
Coverage 89.65% 89.66%
==============================================
Files 276 276
Lines 59790 59988 +198
Branches 7471 7499 +28
==============================================
+ Hits 53605 53786 +181
- Misses 4041 4050 +9
- Partials 2144 2152 +8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #8935 (fadced9).
Adapts four loops to release-12.1’s
foreach_ptrmacro. Preserves the merged behavior and regression tests.