fix(ego-browser): refresh session after opening tab - #290
Open
mameikagou wants to merge 1 commit into
Open
Conversation
mameikagou
marked this pull request as ready for review
August 17, 2026 09:04
mameikagou
force-pushed
the
agent/refresh-new-tab-session-dev
branch
from
August 21, 2026 05:06
91d015b to
0de746f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newTab()creates a targetWhy
newTab()returned the new target ID without updating session selection. BecauseensureSession()caches the current session for two seconds, an immediate wait or page command could continue operating on the previously active tab.switchTab()already invalidates the session and sets a preferred target; this applies the same transition after native tab creation.Impact
Commands issued immediately after
newTab()or the new-tab branch ofopenOrReuseTab()now attach to the created tab instead of briefly reusing the prior tab's session.Validation
npm test— 312 tests passed