-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(server/commands): Document increase_pool_size command #481
docs(server/commands): Document increase_pool_size command #481
Conversation
0cefb34
to
bd66970
Compare
Allowing us to change any pool size can help us to do testing in production environment. |
The restrictions are there to make it harder for people to shoot themselves in a leg. If there is a case where higher limits are needed - we can easily adjust them. But I understand your concern about testing. We could add a special "dangerous" flag that would remove the restrictions. But I'm not sure myself. @prikolium-cfx WDYT? |
every server has its own needs, I think flexibility is a must. |
Redm is still at very experimental state, it's will be easy to increase some pool as testing purpose, like ped, vehicle ect ... |
Maybe we can add startup argument |
Thats a good question. The pool size limits are stored in a CDN, so you won't be able to change them by creating a PR anyway. I'm not sure. Im not sure what the best communication channel would be. If you are part of the CFX discord channel - you can write there and ping me or @prikolium-cfx . If not - you can just send a direct message on discord to one of us. My username on discord is "nobeliumcfx"
Sounds good. There are higher priority tasks for me at the moment. But it should be fast to do. I'll make make sure to add the flag once I have some time. |
yes its been 5 years in experimental state...
what would be the point in testing things if we can't use in production? most tests are done in production specially testing and seeing pool sizes, and then we need to ask and wait, and wait to be in release version to use it. that's a lot of steps. The flag is a good idea but I think its unacessery code that will stay forever in the code base. not that is any of my concern just an observation in my opinion just don't restric it, it should be the server responsability on how they use it. |
You'll not have to wait for it to be in release version, the list is the same for all versions. This is recent so yes the pool restrictions list will be edited a few times but over time the list will be more and more stable, if someone need a limit to be adjusted he will request Cfx team once he proves this is needed. Something that is missing is the information of how to request adjustments of the limits, this should be notified in the console when hitting a pool restriction so anyone that needs to up the limit will know how he should request it. |
I just see it all as unaccessary, there should be no need to contact anyone and have to proove their use case, that's how it was before, so we are going backwards? hence why the flag could come into play, but still, why restrict when it's the server responsability? removing the restriction (either default or by convar) allows users to test them and report issues if any, no need to contact anyone and leave it all to the team to handle it. That's how I see it. |
bd66970
to
b050327
Compare
b050327
to
2c676b5
Compare
First of all thankyou i was stuck on 2612 for a while, this allows me to go current and give me 15% room to play so any improvements are appreciated, and like said before if possible to give responsibility to the server to test some pools would be great |
@outsider31000 , @Korioz , @Identity-labs , @iafondo FYI: We've just merged citizenfx/fivem@7dbd3d3 to Canary. This will allow the requested experimental behavior. See #507 for more details on how to use it. Sorry for taking some time with it. Made it as soon as I've got free from some other tasks. |
thank you |
is increasing the pool limit for networked objects possible ? right now once you pass that limit the object automatically despawns @Nobelium-cfx |
Even adding more Ambiant Mask Volume to the pool size: citizenfx/fivem#2821 could be amazing too :) |
I believe you can already do that see: https://github.com/citizenfx/fivem-docs/pull/507/files although is not advised to use in production you can. |
No, we already tried for these issue sadly :( |
On canary with latest artifacts? not sure if it's in production |
@kamelzarandah Maybe. Can you give me a bit more context?
@outsider31000 It is only available on Canary right now. It will get to beta and production with the regular beta/prod push.
@SevenLife Did you increase the pool but it didn't help? Or you couldn't increase the pool size at all? If its the first - then the pool size increase can't help the issue at all and we should search for some other ways to deal with it. If the second - please let me know, I should take a look into it then.
Yes, please don't use it in production. Instead, if you test the size increase with it and it works for you and resolves the problem - then its much easier for me to just add it to allow list because I know that it indeed worksw |
Thanks Nobelium, we will run some test soon, it's more likelly @zetafe1 how have found this issue but this will impact all server in the futur for sure. |
No description provided.