Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OSCOLA CSL style that uses journal abbreviations, if they are… #7452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aarontimo
Copy link
Contributor

… available. If no journal abbreviation is present, then the full title appears.

Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

35 tests failed

afro-asia: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [27, "27:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

anabases: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

antiquites-africaines: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

aquitania: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[19, "19:0: ERROR: Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

archaeonautica: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

ausonius-editions: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[21, "21:0: ERROR: Did not expect element locale there"], [21, "21:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

bulletin-de-correspondance-hellenique: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

chicago-author-date-basque: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

deutsches-archaologisches-institut: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

embnet-journal: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element macro there"], [20, "20:0: ERROR: Element style has extra content: macro"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

institut-francais-darcheologie-orientale-en: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [21, "21:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

institut-francais-darcheologie-orientale: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

institut-pertanian-bogor: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [25, "25:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

institut-teknologi-bandung-sekolah-pascasarjana: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

interdisziplinare-anthropologie: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...: Did not expect element macro there"], [20, "20:0: ERROR: Element style has extra content: macro"]].empty?` to be truthy, got false

irish-historical-studies: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[23, "23:0: ERROR: Did not expect element locale there"], [23, "23:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

journal-of-jewish-studies: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

journal-of-neolithic-archaeology: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

maison-de-l-orient-et-de-la-mediterranee-en: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [24, "24:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

maison-de-l-orient-et-de-la-mediterranee: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [24, "24:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

societe-archeologique-de-bordeaux: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[19, "19:0: ERROR: Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

society-of-biblical-literature-fullnote-bibliography: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [33, "33:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

universitat-basel-iberoromanistik: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

universitat-bern-institut-fur-musikwissenschaft-note: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

university-of-zabol-fa: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

wiley-vch-books: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[18, "18:0: ERROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/bibliotheca-ephemeridum-theologicarum-lovaniensium: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/bioethics: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/british-journal-of-clinical-pharmacology: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/environmental-toxicology-and-chemistry: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/immunological-reviews: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/information-systems-journal: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/institut-catholique-de-paris: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/universite-paris-diderot-ufr-detudes-psychanalytiques: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/zurcher-hochschule-fur-angewandte-wissenschaften-zitierguide: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

Copy link

😟 There are some issues with your submission.

35 tests failed

afro-asia: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [27, "27:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

anabases: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

antiquites-africaines: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

aquitania: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[19, "19:0: ERROR: Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

archaeonautica: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

ausonius-editions: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[21, "21:0: ERROR: Did not expect element locale there"], [21, "21:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

bulletin-de-correspondance-hellenique: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

chicago-author-date-basque: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

deutsches-archaologisches-institut: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

embnet-journal: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element macro there"], [20, "20:0: ERROR: Element style has extra content: macro"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

institut-francais-darcheologie-orientale-en: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [21, "21:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

institut-francais-darcheologie-orientale: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

institut-pertanian-bogor: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [25, "25:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

institut-teknologi-bandung-sekolah-pascasarjana: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

interdisziplinare-anthropologie: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...: Did not expect element macro there"], [20, "20:0: ERROR: Element style has extra content: macro"]].empty?` to be truthy, got false

irish-historical-studies: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[23, "23:0: ERROR: Did not expect element locale there"], [23, "23:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

journal-of-jewish-studies: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

journal-of-neolithic-archaeology: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...RROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

maison-de-l-orient-et-de-la-mediterranee-en: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [24, "24:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

maison-de-l-orient-et-de-la-mediterranee: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [24, "24:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

societe-archeologique-de-bordeaux: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[19, "19:0: ERROR: Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

society-of-biblical-literature-fullnote-bibliography: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [33, "33:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

universitat-basel-iberoromanistik: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [19, "19:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

universitat-bern-institut-fur-musikwissenschaft-note: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

university-of-zabol-fa: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

wiley-vch-books: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[18, "18:0: ERROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/bibliotheca-ephemeridum-theologicarum-lovaniensium: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/bioethics: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/british-journal-of-clinical-pharmacology: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/environmental-toxicology-and-chemistry: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/immunological-reviews: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/information-systems-journal: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/institut-catholique-de-paris: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/universite-paris-diderot-ufr-detudes-psychanalytiques: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

dependent/zurcher-hochschule-fur-angewandte-wissenschaften-zitierguide: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[2, "2:0: ERROR: Invalid attribute class for element style"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

@aarontimo
Copy link
Contributor Author

Sorry - not sure why this is failiing. I used the CSL Validator 1.0.2, strict 1.0.2 and 1.0.1 and it passed. No issues. I used the CSL Visual Editor to make the changes. Why is it soooo hard to update/improve styles??

@adam3smith
Copy link
Member

It's not your style that's failing, something else is going on

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Feb 28, 2025
@adam3smith
Copy link
Member

Your pull request is based on an ancient, unsynced fork, so you're picking up a bunch of issues with style in your fork that still follow CSL 1.0.1.

See if you can sync the fork using the button on https://github.com/aarontimo/styles/tree/update-oscola-style
image

@adam3smith
Copy link
Member

But I'm actually not sure that we want this change (though thanks for submitting it!)-- the current version is deliberate:
OSCOLA allows the use of full journal titles. Automated abbreviations will, by default, come out wrong for users, e.g., of Zotero because the default is to use automated MEDLINE style journal abbreviations -- so we'll start by confusing users who aren't aware of that distinction. Then, many journals automatically import journal abbreviations into reference managers -- again, those would most likely not be conformant to OSCOLA abbreviations: again, we confuse users. Finally there may be cases when there are good reasons to keep journal abbreviations in the metadata but not use OSCOLA journal abbreviations: again, this version of the style would make this impossible.
Given all this (and the fact that I dont' think we ever got a request for this change), I think we'll want to leave the official version as is. You're obviously more than welcome to use and even distribute yourself the version which defaults to abbreviations.

@aarontimo
Copy link
Contributor Author

aarontimo commented Mar 2, 2025 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants