Restore config singleton and fix package declarations - #118
Merged
Conversation
csco-abp
approved these changes
Aug 1, 2026
urajat
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigandAsyncConfigaidefenseRoot cause
PR #113 removed the singleton implementation from
BaseConfigwhile adding the validation SDK. The existing configuration tests and downstream callers still rely on the singleton contract. The same PR also declared nonexistent top-level packages, which preventedpoetry installfrom installing the project.Impact
This restores the SDK's previous configuration behavior without removing or modifying the validation SDK. A built wheel contains all 24 modules under
aidefense.validationandaidefense.pydantic.validation.Validation
poetry checkpoetry run pytest aidefense/tests/test_config.py- 15 passedpoetry run pytest- 600 passed, 8 skippedgit diff --check