tart {clone,pull}: support --proxy, --ca-cert and --max-retries #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Mar 9, 2025
| throw RuntimeError.FailedToLoadCACertificate("failed to parse Base64-encoded PEM data") | ||
| } | ||
|
|
||
| self.caCert = SecCertificateCreateWithData(nil, caCertData as CFData)! |
There was a problem hiding this comment.
Is it an additional one? It seems it's possible to pass a certificate without proxy and then I wonder if regular requests will work?
There was a problem hiding this comment.
It's not, but can be made so by calling SecTrustSetAnchorCertificatesOnly().
fkorotkov
approved these changes
Mar 20, 2025
fkorotkov
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these options, we can first try to run
tart {clone,pull}with--proxy <local caching HTTP proxy> --ca-cert <TLS interceptor's CA certificate> --max-retries 1, and if it fails, run it a second time without these options as a fallback.The options are hidden for now because I'm not yet sure if it's the right approach.