Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve connection step updating and add checkmarks #298

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

makermelissa
Copy link
Collaborator

This completes another step in #43. While adding code to mark steps complete, I was able to abstract the function to enable/disable buttons.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work with an emoji check instead of an svg?✔️

Also, could you add a short screen capture to show what this looks like? Thanks!

@makermelissa
Copy link
Collaborator Author

Sure, I could give it a try. It should work in theory. I'll see how it looks though.

@makermelissa
Copy link
Collaborator Author

I think the SVG looks better. Here's a comparison:
Screenshot 2025-02-18 at 3 45 56 PM
Screenshot 2025-02-18 at 3 42 01 PM

Here' a screen recording to see it in action:
https://github.com/user-attachments/assets/02e40b89-ebab-423c-8d1b-8614da894eaa

@tannewt
Copy link
Member

tannewt commented Feb 19, 2025

Thank you for the screen recording! Do we need to show step 1 at that point at all? Why not just show step 2? Earlier it only shows step 1.

@makermelissa
Copy link
Collaborator Author

It allows users to still connect to a different device in case they selected the wrong one or to go forward with step 2.

@tannewt
Copy link
Member

tannewt commented Feb 20, 2025

I'm not convinced you need to do that here. They can always disconnect and click connect again.

If you do want to show it still, then I'd update the step 1 info with what was selected. That way one can tell if the correct thing was selected.

@makermelissa
Copy link
Collaborator Author

After trying out some things, I think you're correct. I updated the code to disable the Connect to Device button. I don't want to remove the step altogether because the CSS would automatically renumber the steps and step 2 would appear to be step 1.

@dhalbert
Copy link
Contributor

dhalbert commented Mar 3, 2025

One thing I noticed recently is that when the UF2 is downloaded and then uploaded to the board, the progress bar just says "Downloading": it's not two steps. Or am I missing something?

@dhalbert
Copy link
Contributor

dhalbert commented Mar 3, 2025

One thing I noticed recently is that when the UF2 is downloaded and then uploaded to the board, the progress bar just says "Downloading": it's not two steps. Or am I missing something?

Sorry, never mind, thought this was the web installer.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

@tannewt tannewt merged commit 71b617a into circuitpython:beta Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants