Skip to content

fix: attach risk signals to all DAA endpoints that require them - #479

Merged
anilgangapersaud-circle merged 1 commit into
circlefin:masterfrom
yitianx00:claude/withdrawals-api-risk-signals-9d64f1
Sep 3, 2026
Merged

anilgangapersaud-circle merged 1 commit into
circlefin:masterfrom
yitianx00:claude/withdrawals-api-risk-signals-9d64f1

Conversation

@yitianx00

Copy link
Copy Markdown
Contributor

Summary

  • Digital Asset Accounts withdrawal, transfer, and recipient-address creation requests were missing riskSignals, so the API rejects them with "Risk signals required." Wire account creation already attached them correctly.
  • Per the accounts.yaml OpenAPI spec (components.schemas), riskSignals is required on exactly four request schemas: AccountWireCreationRequest, AccountWithdrawalCreationRequest, AccountTransferCreationRequest, and AccountRecipientAddressCreationRequest. Account creation, ACH, and deposit-address creation do not require it.
  • Mirrors the existing wire-account pattern: pull riskSignals from the global settings-drawer store (store.getRiskSignals) into each payload.
  • Updated the settings-drawer hint text, which previously only mentioned wire accounts, to list all four endpoints that require risk signals.

Test plan

  • Verified against the published OpenAPI spec at https://developers.circle.com/openapi/accounts.yaml which endpoints require riskSignals
  • Ran the app locally against api-smokebox.circle.com and confirmed each payload now includes riskSignals
  • Manually create a withdrawal, transfer, and recipient address against smokebox with risk signals filled in via the settings drawer and confirm the requests succeed

🤖 Generated with Claude Code

Withdrawals, transfers, and recipient-address creation were sending
requests without riskSignals, which the API rejects. Wire account
creation already did this correctly; mirror that pattern for the
other three endpoints per the accounts.yaml OpenAPI spec.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@anilgangapersaud-circle
anilgangapersaud-circle merged commit 866612e into circlefin:master Sep 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants