DAE-3851: fix: skip trader signing for auto-confirmed maker delegate trades - #476
Open
anilgangapersaud-circle wants to merge 1 commit into
Open
anilgangapersaud-circle wants to merge 1 commit into
anilgangapersaud-circle wants to merge 1 commit into
Conversation
When only funderPermitTypedData is returned (auto-confirmed makers), skip the trader signing step and still mark the entry as signed once the funder permit is collected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: DAE-3851
Summary
For auto-confirmed maker delegate trades, only
funderPermitTypedDatais returned from the presign API —traderPermitTypedDatais absent. Previously, the signing loop would unconditionally attempt to sign the trader permit, andallDelegateSignedrequired both signatures, leaving the flow stuck.Changes
traderTypedDatais nullallDelegateSignedand the per-entry "Signed" chip only requiretraderSignaturewhentraderTypedDatawas actually presentTest plan
funderPermitTypedData— verify Sign With Circle skips trader step and marks entry as Signed after funder only🤖 Generated with Claude Code