Skip to content

feat: Stop Node actor on any child failure/termination #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
romac wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Stop Node actor on any child failure/termination #1498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions code/crates/engine/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use async_trait::async_trait;
use ractor::{Actor, ActorProcessingErr, ActorRef, SupervisionEvent};
use tokio::task::JoinHandle;
use tracing::{error, info, warn};
use tracing::{error, info};

use malachitebft_core_types::Context;

Expand Down Expand Up @@ -74,8 +74,8 @@ where
self.host.link(myself.get_cell());
self.wal.link(myself.get_cell());

if let Some(actor) = &self.sync {
actor.link(myself.get_cell());
if let Some(sync) = &self.sync {
sync.link(myself.get_cell());
}

Ok(())
Expand All @@ -94,24 +94,33 @@ where
#[tracing::instrument(name = "node", parent = &self.span, skip_all)]
async fn handle_supervisor_evt(
&self,
_myself: ActorRef<Self::Msg>,
myself: ActorRef<Self::Msg>,
evt: SupervisionEvent,
_state: &mut (),
) -> Result<(), ActorProcessingErr> {
match evt {
SupervisionEvent::ActorStarted(cell) => {
info!(actor = %cell.get_id(), "Actor has started");
SupervisionEvent::ActorStarted(who) => {
info!(actor = %who.get_id(), "Actor has started");
}
SupervisionEvent::ActorTerminated(cell, _state, reason) => {
warn!(
"Actor {} has terminated: {}",
cell.get_id(),
reason.unwrap_or_default()
);

SupervisionEvent::ActorTerminated(who, _state, reason) => {
let reason = reason.unwrap_or_else(|| "no reason provided".to_string());

error!(actor = %who.get_id(), "Actor has terminated, shutting down node: {reason}");

myself.stop(Some(format!(
"Shutting down node due to child actor termination: {reason}",
)));
}

SupervisionEvent::ActorFailed(cell, error) => {
error!("Actor {} has failed: {error}", cell.get_id());
error!(actor = %cell.get_id(), "Actor has failed, shutting down node: {error:?}");

myself.stop(Some(format!(
"Shutting down node due to child actor failure: {error:?}",
)));
}

SupervisionEvent::ProcessGroupChanged(_) => (),
}

Expand Down