fix(driver): decide in a future round upon PrecommitValue(v) vote keeper output#1483
Open
cason wants to merge 11 commits intocirclefin:mainfrom
Open
fix(driver): decide in a future round upon PrecommitValue(v) vote keeper output#1483cason wants to merge 11 commits intocirclefin:mainfrom
PrecommitValue(v) vote keeper output#1483cason wants to merge 11 commits intocirclefin:mainfrom
Conversation
* Currently, it fails when the decision is reached with votes * It works when the decision is reached with a commit certificate
* A bit less atrocious solution for the multiplex method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1480.
In the following scenario the vote keeper can produce both
SkipRound(r)andPrecommitValue(v):Precommit(r, v);ris larger than the current's process round;rwere received from1/3+processes;Precommit(r, v)was received from2/3+processes.The current implementation of the vote keeper opts to output
SkipRound(r)in this scenario, therefore postponing the decision, which depends on the reception of an additional event at roundr. This is problematic for two reasons:ProposedValue(v, validity)when starting roundr;Commitcertificate for(r, v)is received, instead of aPrecommitleading to a quorum, the decision is immediate.This PR changes the behaviour of the vote keeper to produced a
PrecommitValue(v)in this scenario. In order to cover the scenarios whenPrecommitValue(r, v)does not lead to a decision - namely, whenProposal(v, r)is not available orvis invalid - a fall back mechanism is added to the driver to applySkipRound(r)to the state machine instead.