Skip to content

test: Attempt to fix flaky equivocation test #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
romac wants to merge 4 commits into
base: main
Choose a base branch
from
+25 −39
Draft

test: Attempt to fix flaky equivocation test #1457

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c79f379
test: Attempt to fix flaky equivocation test
romac Feb 6, 2026
5b9a3f2
More debug
romac Feb 6, 2026
c7211e5
More debug, part 2
romac Feb 6, 2026
5cce522
Increase timeout
romac Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 25 additions & 39 deletions code/crates/test/tests/it/equivocation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ use malachitebft_test_framework::{HandlerResult, TestParams};

use crate::TestBuilder;

const VOTE_DURATION: Duration = Duration::from_millis(300);

fn check_decided_impl<Ctx: Context>(evidence: &MisbehaviorEvidence<Ctx>) {
fn check_evidence<Ctx: Context>(evidence: &MisbehaviorEvidence<Ctx>) {
for addr in evidence.proposals.iter() {
let list = evidence.proposals.get(addr).unwrap();
if let Some((p1, p2)) = list.first() {
Expand All @@ -28,7 +26,7 @@ fn check_decided_impl<Ctx: Context>(evidence: &MisbehaviorEvidence<Ctx>) {

// Verifies that sharing a validator key across two nodes
// induces equivocation and that decide-time `MisbehaviorEvidence`
// contains double proposals and double prevotes for the equivocator.
// contains double proposals for the equivocator.
// Node 3 checks for proposal equivocation evidence.
#[tokio::test]
pub async fn equivocation_two_vals_same_pk_proposal() {
Expand All @@ -40,40 +38,34 @@ pub async fn equivocation_two_vals_same_pk_proposal() {
let mut test = TestBuilder::<()>::new();

// Node 1
test.add_node()
.start()
.on_vote(|_v, _s| Ok(HandlerResult::SleepAndContinueTest(VOTE_DURATION)))
.success();
test.add_node().start().success();

// Node 2 (same validator key as node 1)
test.add_node()
.start()
.on_vote(|_v, _s| Ok(HandlerResult::SleepAndContinueTest(VOTE_DURATION)))
.success();
test.add_node().start().success();

// Node 3 -- checking proposal equivocation evidence
test.add_node()
.start()
.on_vote(|_v, _s| Ok(HandlerResult::SleepAndContinueTest(VOTE_DURATION)))
.on_decided(|_c, evidence, _s| {
check_decided_impl(&evidence);
let result = if evidence.proposals.is_empty() {
HandlerResult::WaitForNextEvent
} else {
HandlerResult::ContinueTest
};
Ok(result)
dbg!(&evidence);

if evidence.proposals.is_empty() {
eyre::bail!("Expected proposal equivocation evidence, but none was found");
}

check_evidence(&evidence);
Ok(HandlerResult::ContinueTest)
})
.success();

test.build()
.run_with_params(Duration::from_secs(15), params)
.run_with_params(Duration::from_secs(30), params)
.await;
}

// Verifies that sharing a validator key across two nodes
// induces equivocation and that decide-time `MisbehaviorEvidence`
// contains double proposals and double prevotes for the equivocator.
// contains double prevotes for the equivocator.
// Node 3 checks for vote equivocation evidence.
#[tokio::test]
pub async fn equivocation_two_vals_same_pk_vote() {
Expand All @@ -85,33 +77,27 @@ pub async fn equivocation_two_vals_same_pk_vote() {
let mut test = TestBuilder::<()>::new();

// Node 1
test.add_node()
.start()
.on_vote(|_v, _s| Ok(HandlerResult::SleepAndContinueTest(VOTE_DURATION)))
.success();
test.add_node().start().success();

// Node 2 (same validator key as node 1)
test.add_node()
.start()
.on_vote(|_v, _s| Ok(HandlerResult::SleepAndContinueTest(VOTE_DURATION)))
.success();
test.add_node().start().success();

// Node 3 -- checking vote equivocation evidence
test.add_node()
.start()
.on_vote(|_v, _s| Ok(HandlerResult::SleepAndContinueTest(VOTE_DURATION)))
.on_decided(|_c, evidence, _s| {
check_decided_impl(&evidence);
let result = if evidence.votes.is_empty() {
HandlerResult::WaitForNextEvent
} else {
HandlerResult::ContinueTest
};
Ok(result)
dbg!(&evidence);

if evidence.votes.is_empty() {
eyre::bail!("Expected vote equivocation evidence, but none was found");
}

check_evidence(&evidence);
Ok(HandlerResult::ContinueTest)
})
.success();

test.build()
.run_with_params(Duration::from_secs(15), params)
.run_with_params(Duration::from_secs(30), params)
.await;
}
Loading