refactor(sync): Refactor the sync scoring system#1449
Open
romac wants to merge 11 commits intocirclefin:mainfrom
Open
refactor(sync): Refactor the sync scoring system#1449romac wants to merge 11 commits intocirclefin:mainfrom
romac wants to merge 11 commits intocirclefin:mainfrom
Conversation
… individual scoring strategies and into PeerScorer
…-zero probability of being selected
romac
force-pushed
the
sync/score-refactor
branch
from
ef5bf06 to
828c3f8
Compare
romac
commented
Feb 13, 2026
Comment on lines
+180
to
+183
| // Use a minimum floor so that even the lowest-scoring peers | ||
| // retain a non-zero probability of being selected. | ||
| const MIN_WEIGHT: f64 = 0.01; | ||
| let scores = peers.iter().map(|id| self.get_score(id).max(MIN_WEIGHT)); |
Contributor
Author
There was a problem hiding this comment.
I wonder whether we want to keep this behavior or not? I've only added it so that the credit strategy would not cause scores to drop to 0, to match the emergent property of the EMA scoring system that scores are never quite zero (cf. See the pre-existing all_peers_selectable test).
At some point, we probably want to be ban/disconnect from peers whose score has dropped to zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1448
Actual changes: