Draft
Conversation
784bb1a to
4ea83e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
This PR is temporary to help us testing quickly with different combinations of libp2p options (e.g. enable_peer_scoring, enable_explicit_peering, enable_flood_publish, persistent_peers_only) on different setups.
To test on consensus repository you can use these helpers:
Script to quickly init, start, stop, restart nodes here
App used informalsystems-malachitebft-example-channel.
Has the env flags:
Script to help network checks here
TODO:
rebase to persistent_peers_only https://github.com/circlefin/circle-chain-consensus/pull/54 or sync with main if that is merged.I think this is donePR author checklist
Contribution eligibility
For all contributors
RELEASE_NOTES.mdif the change warrants itBREAKING_CHANGES.mdif the change warrants itFor external contributors