Add room events to timeline #646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 507b428.
bikkimahato
reviewed
Jul 11, 2022
src/app/organisms/room/common.jsx
Outdated
Comment on lines
217
to
221
| switch (type) { | ||
| case 'm.room.name': return makeReturnObj('edit', tJSXMsgs.roomNameChanged(senderName, content.name)); | ||
| case 'm.room.topic': return makeReturnObj('edit', tJSXMsgs.roomTopicChanged(senderName)); | ||
| case 'm.room.avatar': return makeReturnObj('edit', tJSXMsgs[content.url ? 'roomAvatarChanged' : 'roomAvatarRemoved'](senderName)); | ||
| } |
There was a problem hiding this comment.
It's always a good practice to have deafult case.
There was a problem hiding this comment.
in this case we want the case to fall through if it's not handled by any of these cases, so that it can be caught by the second switch/case a little bit below
ginnyTheCat
reviewed
Aug 1, 2022
kfiven
requested changes
Aug 12, 2022
ajbura
requested changes
Aug 14, 2022
Comment on lines
+37
to
+39
| case 'edit': | ||
| iconSrc = HashIC; | ||
| break; |
There was a problem hiding this comment.
Suggested change
| case 'edit': | |
| iconSrc = HashIC; | |
| break; | |
| case 'room-profile': | |
| iconSrc = HashIC; | |
| break; |
variant propTypes for this is also missing.
|
this exists in and was merged with #1346 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds room name and topic changes to the room timeline.
Type of change
Checklist:
Preview: https://62f6373d02985a2f943f21ab--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️