Skip to content

Conversation

WebFreak001
Copy link
Contributor

Description

The invitations list now shows "on server.domain" for whoever invited you:

image

Some servers are particularly prone to spam users, this helps identifying spam invites early on.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • n/a: I have commented my code, particularly in hard-to-understand areas
  • n/a: I have made corresponding changes to the documentation
  • My changes generate no new warnings

Some servers are particularly prone to spam users, this helps identifying spam invites early on.
Copy link

Preview: https://2016--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Comment on lines +111 to +116
{serverName && (
<>
{' on '}
<b>{serverName}</b>
</>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think displaying only serverName wont be sufficient here as we only display display_name and the username part could be anything. maybe we should show the entire userId as "Invited by name (@ name:server.name)"

Copy link
Contributor Author

@WebFreak001 WebFreak001 Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure this depends just on how much we want to show here, so I can change it to

Suggested change
{serverName && (
<>
{' on '}
<b>{serverName}</b>
</>
)}
{serverName && (
<>
{' ('}
<b>{senderId}</b>
{')'}
</>
)}

as well.

Could look a bit more cluttered now, depends on the trade of between form and function that you want to take here. Perhaps we should make this part a bit lighter.

Feel free to just apply the suggestion if you prefer this way.

@ajbura ajbura self-requested a review February 16, 2025 04:37
@kfiven
Copy link
Collaborator

kfiven commented Jun 18, 2025

From the changes after spam invite management, we have full user id in invite, so closing this one.

@kfiven kfiven closed this Jun 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants