Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor timeline #1346

Merged
merged 172 commits into from
Oct 6, 2023
Merged

Refactor timeline #1346

merged 172 commits into from
Oct 6, 2023

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Jul 21, 2023

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Preview: https://1346--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura ajbura marked this pull request as draft July 21, 2023 15:59
@tezlm
Copy link

tezlm commented Oct 4, 2023

Some feedback after test driving the new ui design, sorry in advance if this is a lot or planned to be added/fixed

  • The message right click/context menu is nice, but it would be nicer if it opened the menu where the click happened
  • The buttons seem harder to click or don't "feel as good", the padding should probably be increased (while maybe decreasing margins)
    • The message toolbar seems finnicky to access, since i can't approach it an angle (only directly from the bottom)
    • The "back button" on the file preview modal is tiny and seeminly useless since I can click on the background
  • The design being partially old style and partially new style/folds is jarring at times
  • Sometimes uploading files can upload as the wrong type or octet-stream (ie. typescript, mov occasionally)
  • There's no way to edit a message currently
  • There's no way to hide deleted message tombstones
  • The image viewer lets me pan the image by dragging, but only when it's not at 100% zoom; i don't know if its better to be able to drag/drop images or have a consistent ui
  • Media no longer has a "one click download" button, which looks cleaner but does hurt usability a bit (i like to archive stuff)
  • Showing the user id separately from the username (instead of hover) is and (imo) better overall, but might clutter the ui a bit
  • Typing notifications don't seem to currently work (note: this might be my server having issues)
  • There's no indication that a <details> element is clickable, maybe add summary { cursor: pointer; }?
  • Tables don't have any styling
  • m.notices changing color is nice but currently seems a bit too subtle. m.emote stands out too much
  • <code class="language-*"> outside of <pre>s have broken styling
  • Clicking "watch" on a video can cause the browser spinner and the cinny spinner to load at the same time
  • LaTeX no longer works
  • "View Reactions" is prone to breaking
  • There is no indicator for encrypted rooms
  • Opening the reaction picker seems a bit laggy, try memoizing it if you aren't already
  • There is no indicator for messages that notified me (i can see mentions, but not reply or keyword pings)
  • Location messages used to show previews (in previous commits) but seems to have been broken?
  • Maybe the text preview modal should render markdown files? If this is added, a toggle could be added to switch between plain/rendered views.
  • The message toolbar icons might not disappear if you right click multiple messages at a time (screenshot)

Despite all this, the redesign is really nice! Thank you for working on Cinny

@ajbura
Copy link
Member Author

ajbura commented Oct 5, 2023

"View Reactions" is prone to breaking

@tezlm can you provide more details on this?

@tezlm
Copy link

tezlm commented Oct 5, 2023

This message supposedly has 6 bird reactions:

image

But viewing reactions only shows 5:

image

This was loaded by scrolling up, but it can also happen from search results, jump to unread, jump to reply, etc.

@ajbura
Copy link
Member Author

ajbura commented Oct 6, 2023

ok thanks.

I am going to merge this now. And will add missing features or fix bug in next one.

@ajbura ajbura marked this pull request as ready for review October 6, 2023 02:42
@ajbura ajbura merged commit 3a95d0d into dev Oct 6, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants