Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the usePermission hook to render correctly on iOS 16.4 #1231

Closed
wants to merge 1 commit into from

Conversation

jasikpark
Copy link

Description

Before this change, the state of the notification permission status on iOS would not be rendered correctly after enabling it.

This PR refactors the usePermission hook to subscribe to the notification permissions correctly

Annoyingly, this isn't the entirety of why iOS notifications aren't working yet...

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Before this change, the state of the notification permission status on iOS would not be rendered correctly after enabling it.

This PR refactors the `usePermission` hook to subscribe to the notification permissions correctly
@jasikpark
Copy link
Author

@jasikpark
Copy link
Author

ah, I guess #17 is blocking this actually being useful...

@jasikpark jasikpark mentioned this pull request May 7, 2023
@jasikpark jasikpark closed this Oct 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant