Fixed cinny verified device failed to verify other

cinnyapp · May 8, 2022 · 2075a57 · 2075a57
1 parent 73723ba
commit 2075a57
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/app/organisms/emoji-verification/EmojiVerification.jsx b/src/app/organisms/emoji-verification/EmojiVerification.jsx
@@ -28,7 +28,10 @@ function EmojiVerificationContent({ data, requestClose }) {
   const mountStore = useStore();
 
   const beginVerification = async () => {
-    if (mx.getCrossSigningId() === null && isCrossVerified(mx.deviceId)) {
+    if (
+      isCrossVerified(mx.deviceId)
+      && (mx.getCrossSigningId() === null || await mx.crypto.crossSigningInfo.isStoredInKeyCache('self_signing') === false)
+    ) {
       if (!hasPrivateKey(getDefaultSSKey())) {
         const keyData = await accessSecretStorage('Emoji verification');
         if (!keyData) {
@@ -66,18 +69,21 @@ function EmojiVerificationContent({ data, requestClose }) {
   useEffect(() => {
     mountStore.setItem(true);
     const handleChange = () => {
+      if (request.done || request.cancelled) {
+        requestClose();
+        return;
+      }
       if (targetDevice && request.started) {
         beginVerification();
       }
-      if (request.done || request.cancelled) requestClose();
     };
 
     if (request === null) return null;
     const req = request;
     req.on('change', handleChange);
     return () => {
       req.off('change', handleChange);
-      if (!req.cancelled && !req.done) {
+      if (req.cancelled === false && req.done === false) {
         req.cancel();
       }
     };