Skip to content

Fix makefile so version 1.1 builds#5

Open
guitarmanvt wants to merge 3 commits intocinemascience:masterfrom
guitarmanvt:issue4-yarn-package-management
Open

Fix makefile so version 1.1 builds#5
guitarmanvt wants to merge 3 commits intocinemascience:masterfrom
guitarmanvt:issue4-yarn-package-management

Conversation

@guitarmanvt
Copy link

@guitarmanvt guitarmanvt commented Aug 7, 2019

This resolves Issue #4:

  • Use yum to handle development and build dependencies
  • Update the makefile to build correctly using the current directory structure.
  • Set version file back to 1.1, since there are no 1.2 sources present.
  • Documented browser-specific options that must be set to enable the app to load data from the hard drive.

I can now successfully run make and get a full build in the build folder.

Remaining issues:

  • When I open the HTML files there, I don't see any data. The JavaScript console shows that the browser isn't loading some resources.
  • Are there source files somewhere for version 1.2 that need to be committed to the repository?

@guitarmanvt guitarmanvt changed the title Add yarn package management Fix makefile so version 1.1 builds Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant