observe: Support -f and --first at the same time #1010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 67132c0 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
dont-merge/needs-release-note-label
chancez
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kaworu
requested changes
May 5, 2023
There was a problem hiding this comment.
Hello @sladyn98 and thanks for the PR! Couple of things:
- Please sign-off the commit
- Please add tests on the way around the flags incompatibility. In particular, there should be one test case combining
--followand--firstfailing before the patch, and succeeding after. You can draw inspiration from this test which setup someselectorOptsfields, then callgetFlowsRequest, and finally test assumptions about the returned values.
kaworu
reviewed
May 5, 2023
Comment on lines
-619
to
-621
| if first && selectorOpts.follow { | ||
| return nil, fmt.Errorf("cannot set both --first and --follow") | ||
| } |
There was a problem hiding this comment.
Note for reviewers: removing this check is fine, the Hubble server currently does the same validation on the gRPC request object, and thus we'll still get an error if the server doesn't support combining --first and --follow.
|
@chancez Yeah I am working on it |
|
@sladyn98 Any plans to get this done or should we re-assign? |
|
Closing due to inactivity. Feel free to re-open if you start working on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the safeguard for support for -f and --first at the same time. This would support the following PR in the cilium repository as well to make sure the server supports it as well
Refers to #959