Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version.json #66

Closed
wants to merge 1 commit into from
Closed

Conversation

MarcWort
Copy link

@MarcWort MarcWort commented Sep 10, 2024

Update version.json to reflect current state, debian bookworm-backports and trixie (6.10)

@ti-mo ti-mo requested a review from lmb September 11, 2024 08:40
@ti-mo
Copy link
Contributor

ti-mo commented Sep 11, 2024

@MarcWort Selftests are failing to build on 6.6.50, do you have cycles to investigate and fix? I'm a little short at the moment and @lmb is out. Maybe @florianl or @dylandreimerink could jump in perhaps.

Also, we usually don't include -rc kernels, since they're usually ironing out some bugs. We want to make sure the ebpf-go tests run before we merge, so we don't break CI.

@MarcWort MarcWort force-pushed the update-version-json branch 2 times, most recently from 6590743 to f1058b8 Compare September 11, 2024 14:22
@MarcWort
Copy link
Author

MarcWort commented Sep 11, 2024

That netlink_helpers.h is missing on the 6.6.50 test is weird, I cant find any changes related to that on the kernel sources betweeen 6.6.31 and 6.6.50. I might not be capable to solve this :( .

Also, we usually don't include -rc kernels, since they're usually ironing out some bugs. We want to make sure the ebpf-go tests run before we merge, so we don't break CI.

Sure, I removed it. So there is no non-rc mainline at the moment, is that okay?

@MarcWort
Copy link
Author

MarcWort commented Sep 12, 2024

The error on 6.6.50 is most likely related to
torvalds/linux@b023728

So i guess for 6.6 series we should stay on working 6.6.31 ? For me it is most important to get tests for upcoming debian trixie with kernel >= 6.10 running.

Copy link
Contributor

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at the first CI error, that I have spotted:

#17 52.31 progs/mptcp_sock.c:49:40: error: no member named 'is_mptcp' in 'struct tcp_sock'
#17 52.31         is_mptcp = bpf_core_field_exists(tsk->is_mptcp) ? tsk->is_mptcp : 0;
#17 52.31                                          ~~~  ^
#17 52.31 

But this field wasn't touched for some time in tcp_sock:
https://github.com/torvalds/linux/blob/0c3836482481200ead7b416ca80c68a29cfdaabd/include/linux/tcp.h#L476-L478

versions.json Outdated Show resolved Hide resolved
versions.json Outdated Show resolved Hide resolved
versions.json Outdated Show resolved Hide resolved
@lmb
Copy link
Collaborator

lmb commented Sep 13, 2024

Did you update via https://github.com/cilium/ci-kernels/blob/main/update-versions.sh ? That should pull correct versions automatically.

Update version.json to reflect current state and debian
bookworm-backports (6.10)
@MarcWort
Copy link
Author

@lmb Of course I used update-versions.sh.

Since 6.11 is now released as mainline, I updated the file again.

@ti-mo
Copy link
Contributor

ti-mo commented Oct 1, 2024

Superseded by #67, the build configuration needed a bit of work due to some upstream shenanigans. Thanks @MarcWort!

@ti-mo ti-mo closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants