plots n stuff - #222
Open
benmsanderson wants to merge 1 commit into
Open
Conversation
Contributor
Why are there so many output dump files in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched off add-pdo; PR back once you've had a look.
With delta_lambda_pdo = 0, set_feedback_gregory early-returned and setup_ebud2 never refreshed with the new pdo_index. Now checks pdo_efficacy_scale.
Dropped the hidden current_year counter. energy_budget now takes year_index explicitly (driver passes yr - nystart), removing the rerun/IndexError fragility. Collapsed the dual annual/month-0 update path into a single year-start update. TwoLayerOceanModel gets a matching ignored kwarg.
scripts/pdo_sweep_plot.py — 5×5 sweep over delta_lambda_pdo × pdo_efficacy_scale on SSP2-4.5 1750–2025. Plots dT_glob anomaly and Andrews-2022 30-yr sliding-λ anomaly vs the (0,0) baseline.
To discuss: monthly shape is effectively annual (only month 0 read) — go true-monthly or simplify to annual input?