-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dart-sass, glimmer/component v2 #939
Conversation
Can't seem to get past this error :(
ember-prism looks deprecated/archived I tried adding this to root package.json, with no luck
|
Related ember-power-calendar PR cibernox/ember-power-calendar#527 |
@Techn1x thank for your PR... i will take a look today or next days, but i think we need to remove this package before we can land glimmer v2 support |
Thanks! Let me know if you would like this PR to ditch the glimmer/component v2 changes for now and we can get the sass / pnpm changes merged to start with |
Oooh even better! |
lets see if it works after this changes... #941 |
I'm in the opposite timezone, I won't be at my computer for another 12 hours or so - you're welcome to change/close this PR if you like, otherwise I can remake the glimmer/component V2 update tomorrow |
looks like we can't get a green ci atm, because they are using |
Thanks for sluething that. CI tests prevail! Sounds like they might need an ember-try config over at glimmer/component Given the meaningful changes in this PR have been merged and/or extracted elsewhere, going to close this one |
node-sass
tosass
(aka dart-sass)@glimmer/component
v2 and allow it in peer deps.Not too concerned about the sass change, since it's a build / devdependency. I ran
pnpm build
and it produced the same vendor output (see review comment)The glimmer/component v2 update just drops ember 3.13 and makes it a v2 addon.
https://github.com/emberjs/ember.js/blob/main/packages/%40glimmer/component/CHANGELOG.md
Given the above, I think this is safe to publish as a patch or minor
I couldn't do the glimmer/component update without first ditching node-sass. If you feel it should be separated, feel free to do so, but I felt they are both small enough changes.