Drop @ember/render-modifiers
#714
Conversation
…to a plain modifier
…difiers to a plain modifier
…ers to a plain modifier
…odifier to a plain modifier
| } | ||
| } | ||
| // @ts-ignore | ||
| }, { eager: false }); |
There was a problem hiding this comment.
All modifier() invocations must include { eager: false } since this package supports ember-modifier v3.2.x and v4.
For apps using v3.2.x { eager: false } will ensure the default autotracking behaviour (eager).
For apps using v4 this argument will be ignored.
| // Escape autotracking frame and avoid backtracking re-render | ||
| Promise.resolve().then(() => { | ||
| this.args.dropdown.actions.reposition() |
There was a problem hiding this comment.
This is the only code change I made. Since the did-insert modifier did not participate in auto tracking this was not an issue before.
I'm reasonably confident that this change is compatible since the tests pass. If this modifier doesn't run a number of tests will fail.
Someone more familiar with this library may have a better suggestion to replacing this operation with a derived data pattern (since this is a side-effect type modifier).
|
@mkszepp would you mind reviewing this? |
|
@gilest sry for my delay. it looks good. Thanks |
Replaces the no-longer-recommended render lifecycle modifiers with local function modifiers.
@ember/render-modifierswere meant as a transitional tool from the pre-Octane era, and not long-term usage.Modifier code is directly ported from the setup/teardown hooks with no changes except what I've pointed out in code comments.
Recommend reviewing commit-by-commit.