Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH action proxy jump #219

Merged
merged 9 commits into from
Nov 20, 2024
Merged

SSH action proxy jump #219

merged 9 commits into from
Nov 20, 2024

Conversation

boddissattva
Copy link
Member

Describe the changes you've made

  • Add proxy setup in SSH client action.
  • Add associated acceptance test.with containers.

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@boddissattva boddissattva self-assigned this Nov 12, 2024
@boddissattva boddissattva added the enhancement New feature or request label Nov 12, 2024
@boddissattva boddissattva force-pushed the feat/ssh-action-proxy-jump branch from 7c6351e to 413c8e2 Compare November 12, 2024 18:38
DelaunayAlex
DelaunayAlex previously approved these changes Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.26%. Comparing base (941ea6e) to head (c00d2e2).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/chutneytesting/action/ssh/Connection.java 72.72% 2 Missing and 1 partial ⚠️
...com/chutneytesting/action/ssh/sshj/SshJClient.java 95.12% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #219      +/-   ##
============================================
+ Coverage     60.88%   61.26%   +0.38%     
- Complexity     3341     3417      +76     
============================================
  Files           662      668       +6     
  Lines         18193    18478     +285     
  Branches       1000     1010      +10     
============================================
+ Hits          11076    11321     +245     
- Misses         6718     6743      +25     
- Partials        399      414      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

KarimGl
KarimGl previously approved these changes Nov 17, 2024
DelaunayAlex
DelaunayAlex previously approved these changes Nov 18, 2024
acceptance-tests/pom.xml Show resolved Hide resolved
chutney/packaging/local-dev/pom.xml Outdated Show resolved Hide resolved
@boddissattva boddissattva dismissed stale reviews from DelaunayAlex and KarimGl via abc1fab November 19, 2024 17:06
@boddissattva boddissattva force-pushed the feat/ssh-action-proxy-jump branch from abc1fab to c00d2e2 Compare November 19, 2024 17:27
@nbrouand nbrouand merged commit 2effe53 into main Nov 20, 2024
3 checks passed
@nbrouand nbrouand deleted the feat/ssh-action-proxy-jump branch November 20, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants