Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule campaign: Overload environment and dataset #191

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

nbrouand
Copy link
Member

@nbrouand nbrouand commented Oct 1, 2024

No description provided.

@nbrouand nbrouand added the enhancement New feature or request label Oct 1, 2024
@nbrouand nbrouand force-pushed the feat/dataset_planification branch 4 times, most recently from 4c09d8c to 599c026 Compare October 9, 2024 13:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 88.11881% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.19%. Comparing base (d3db2ec) to head (997140b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ing/campaign/domain/PeriodicScheduledCampaign.java 64.70% 1 Missing and 5 partials ⚠️
...ytesting/campaign/infra/SchedulingCampaignDto.java 50.00% 2 Missing and 3 partials ⚠️
...g/execution/domain/schedule/CampaignScheduler.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #191      +/-   ##
============================================
+ Coverage     60.94%   61.19%   +0.24%     
- Complexity     3361     3408      +47     
============================================
  Files           662      668       +6     
  Lines         18266    18445     +179     
  Branches       1005     1008       +3     
============================================
+ Hits          11133    11287     +154     
- Misses         6729     6745      +16     
- Partials        404      413       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nbrouand nbrouand force-pushed the feat/dataset_planification branch 3 times, most recently from 71d3dd3 to 835089f Compare October 15, 2024 16:02
@nbrouand nbrouand force-pushed the feat/dataset_planification branch from 835089f to 4404d41 Compare October 18, 2024 14:16
@nbrouand nbrouand force-pushed the feat/dataset_planification branch 3 times, most recently from 5c2da43 to 77a472b Compare November 5, 2024 10:07
@nbrouand nbrouand force-pushed the feat/dataset_planification branch from 77a472b to f253ccd Compare November 8, 2024 17:10
@boddissattva boddissattva marked this pull request as ready for review November 12, 2024 09:09
@nbrouand nbrouand force-pushed the feat/dataset_planification branch from f253ccd to 9202cbd Compare November 12, 2024 13:34
@boddissattva

This comment was marked as resolved.

@nbrouand
Copy link
Member Author

Is it normal t obe able to schedule a campaign without an environment ?

yes, there is a default environment defined on campaign

KarimGl

This comment was marked as resolved.

boddissattva
boddissattva previously approved these changes Nov 18, 2024
boddissattva
boddissattva previously approved these changes Nov 18, 2024
@nbrouand nbrouand merged commit 42bc2bc into main Nov 19, 2024
3 checks passed
@nbrouand nbrouand deleted the feat/dataset_planification branch November 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants