security vuln fix, grammar + clarification

[dj1ch]

npm returned a security vulnerability, had to bump vite to 4.5.2(hence the changes to package-lock.json) plus i fixed some grammar to index.md, template.md(template for supported devices), and faq.md. mentioned the security vuln fix(es) with the line i added in contributing.md

screenshot:

[ethanaobrien]

Don't know how I feel about adding this to the instructions when building/running. Npm warns itself that this can break dependencies, and it's never a good idea to manually update a dependencies dependency.

You should attempt upgrading vuepress to 2.0.0-rc.2 first, instead of updating a sub-depenency. This may break things, make sure it works before pushing.

https://www.npmjs.com/package/vuepress/?activeTab=versions

[WeirdTreeThing]

web dev moment

[dj1ch]

Don't know how I feel about adding this to the instructions when building/running. Npm warns itself that this can break dependencies, and it's never a good idea to manually update a dependencies dependency.

You should attempt upgrading vuepress to 2.0.0-rc.2 first, instead of updating a sub-depenency. This may break things, make sure it works before pushing.

https://www.npmjs.com/package/vuepress/?activeTab=versions

so do we update the versions through the package-lock.json? i think you guys can edit the commits right?

[ethanaobrien]

web dev moment

There's nothing different about this than any other programming language.

so do we update the versions through the package-lock.json?

Avoid editing package-lock.json. edit package.json

i think you guys can edit the commits right?

git reset HEAD~1 && git push -f will undo your commit.

For the future, please submit different patches in different prs, it helps with reviewing and merging

[WeirdTreeThing]

There's nothing different about this than any other programming language.

js devs coping is funny

[dj1ch]

web dev moment

There's nothing different about this than any other programming language.

so do we update the versions through the package-lock.json?

Avoid editing package-lock.json. edit package.json

i think you guys can edit the commits right?

git reset HEAD~1 && git push -f will undo your commit.

For the future, please submit different patches in different prs, it helps with reviewing and merging

gotcha, should i resubmit the other changes? (except the package-lock.json)

[dj1ch]

There's nothing different about this than any other programming language.

js devs coping is funny

😭😭😭

[ninelore]

yea package-lock editing is really bad practice

[dj1ch]

@ethanaobrien do i just open up a seperate pr?

[ethanaobrien]

Yes, one for rewording/grammar, one for the security issue

[dj1ch]

Yes, one for rewording/grammar, one for the security issue

will do

[MilkyDeveloper]

🤡🤡🤡

[WeirdTreeThing]

wrong repo

[dj1ch]

🤡🤡🤡

holy sh*t its milky