Skip to content

Commit

Permalink
Disable non-templaet-friend warning in GCC since it's firing in LLVM
Browse files Browse the repository at this point in the history
  • Loading branch information
danakj committed Oct 2, 2023
1 parent 836924c commit 5f89cab
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,14 @@ jobs:
sudo apt-get install g++-13
echo "CXXFLAGS=$CXXFLAGS" >> $GITHUB_ENV
# GCC has a warning on the LLVM 18 codebase now.
# https://github.com/llvm/llvm-project/issues/67942
- name: Disable GCC Warning
if: matrix.config.name == 'Ubuntu GCC'
run: |
echo "CFLAGS=$CFLAGS -Wno-non-template-friend" >> $GITHUB_ENV
echo "CXXFLAGS=$CXXFLAGS -Wno-non-template-friend" >> $GITHUB_ENV
# vptr is incompatible with no-rtti. We turn off rtti to match the LLVM libraries.
- name: Set Sanitizer Flags
if: endsWith(matrix.config.name, 'Sanitizer')
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/try.yml
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,14 @@ jobs:
echo "CFLAGS=$CFLAGS -fsanitize=address -fsanitize=undefined -fno-sanitize=vptr -O0" >> $GITHUB_ENV
echo "CXXFLAGS=$CXXFLAGS -fsanitize=address -fsanitize=undefined -fno-sanitize=vptr -O0" >> $GITHUB_ENV
# GCC has a warning on the LLVM 18 codebase now.
# https://github.com/llvm/llvm-project/issues/67942
- name: Disable GCC Warning
if: matrix.config.name == 'Ubuntu GCC'
run: |
echo "CFLAGS=$CFLAGS -Wno-non-template-friend" >> $GITHUB_ENV
echo "CXXFLAGS=$CXXFLAGS -Wno-non-template-friend" >> $GITHUB_ENV
- name: Download Ninja
id: ninja
shell: cmake -P {0}
Expand Down
2 changes: 1 addition & 1 deletion subdoc/gen_tests/typenames-across-paths/namespace.n.html
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@
<div class="type-signature"><a name="alias.var"></a><a class="type-name" href="other-namespace.subother.html#variable.var">var</a></div>
</div>
<div class="description short">
<p>Forwarding alias of <a href="other-namespace.subother.html#variable.var"><code>var</code></a>.</p>
<p>Deduces to <code>int var</code>.</p>
</div>
</li>
</ul>
Expand Down

0 comments on commit 5f89cab

Please sign in to comment.