MS Visual Studio 2022 17.8.1 can now build again

Update README to say so. Older MSVC crashes in Result now also, so drop the older version.
chromium · Nov 25, 2023 · 242041b · 242041b
1 parent 0452d3b
commit 242041b
Show file tree

Hide file tree

Showing 3 changed files with 94 additions and 94 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,22 +12,22 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          #- {
-          #    name: "Windows MSVC",
-          #    artifact: "Windows-MSVC.tar.xz",
-          #    # MSVC 17.6.3 can no longer build Subspace. 16 doesn't work either.
-          #    # https://developercommunity.visualstudio.com/t/Update-to-1763-now-rejects-valid-C-i/10394500
-          #    os: windows-latest,
-          #    build_type: "Release",
-          #    cc: "cl",
-          #    cxx: "cl",
-          #    environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
-          #  }
-          #- {
-          #    name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
-          #    os: windows-latest,
-          #    build_type: "Release", cc: "gcc", cxx: "g++"
-          #  }
+        # MSVC is broken: https://github.com/chromium/subspace/issues/267
+        #- {
+        #    name: "Windows MSVC",
+        #    artifact: "Windows-MSVC.tar.xz",
+        #    os: windows-latest,
+        #    build_type: "Release",
+        #    cc: "cl",
+        #    cxx: "cl",
+        #    environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
+        #  }
+
+        #- {
+        #    name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
+        #    os: windows-latest,
+        #    build_type: "Release", cc: "gcc", cxx: "g++"
+        #  }
 
         - {
             name: "Ubuntu Clang-16 Debug",

diff --git a/.github/workflows/try.yml b/.github/workflows/try.yml
@@ -15,83 +15,83 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          #- {
-          #    name: "Windows MSVC",
-          #    artifact: "Windows-MSVC.tar.xz",
-          #    # MSVC 17.6.3 can no longer build Subspace. 16 doesn't work either.
-          #    # https://developercommunity.visualstudio.com/t/Update-to-1763-now-rejects-valid-C-i/10394500
-          #    os: windows-latest,
-          #    build_type: "Release",
-          #    cc: "cl",
-          #    cxx: "cl",
-          #    environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
-          #  }
-          #- {
-          #    name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
-          #    os: windows-latest,
-          #    build_type: "Release", cc: "gcc", cxx: "g++"
-          #  }
-
-          - {
-              name: "Ubuntu Clang-16 Debug",
-              os: ubuntu-latest,
-              build_type: "Debug",
-              cc: "clang-16",
-              cxx: "clang++-16",
-              clang_version: 16,
-              installed_clang_version: 14
-            }
-
-          - {
-              name: "Ubuntu Clang-17 Debug",
-              os: ubuntu-latest,
-              build_type: "Debug",
-              cc: "clang-17",
-              cxx: "clang++-17",
-              clang_version: 17,
-              installed_clang_version: 14
-            }
-
-          - {
-              name: "Ubuntu Clang-17 Sanitizer",
-              os: ubuntu-latest,
-              build_type: "Release",
-              cc: "clang-17",
-              cxx: "clang++-17",
-              clang_version: 17,
-              installed_clang_version: 14
-            }
-
-          - {
-              name: "Ubuntu Clang-18 Debug",
-              os: ubuntu-latest,
-              build_type: "Debug",
-              cc: "clang-18",
-              cxx: "clang++-18",
-              clang_version: 18,
-              installed_clang_version: 14
-            }
-
-          - {
-              name: "Ubuntu GCC",
-              os: ubuntu-latest,
-              build_type: "Release",
-              cc: "gcc-13",
-              cxx: "g++-13",
-              clang_version: 18,
-              installed_clang_version: 14
-            }
-
-          # Clang doesn't have good enough C++20 support to compile this library
-          # yet.
-          #- {
-          #    name: "macOS Latest Clang",
-          #    artifact: "macOS.tar.xz",
-          #    os: macos-latest,
-          #    build_type: "Release",
-          #    cc: "clang",
-          #    cxx: "clang++",
-          #  }
+        # MSVC is broken: https://github.com/chromium/subspace/issues/267
+        #- {
+        #    name: "Windows MSVC",
+        #    artifact: "Windows-MSVC.tar.xz",
+        #    os: windows-latest,
+        #    build_type: "Release",
+        #    cc: "cl",
+        #    cxx: "cl",
+        #    environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
+        #  }
+
+        #- {
+        #    name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
+        #    os: windows-latest,
+        #    build_type: "Release", cc: "gcc", cxx: "g++"
+        #  }
+
+        - {
+            name: "Ubuntu Clang-16 Debug",
+            os: ubuntu-latest,
+            build_type: "Debug",
+            cc: "clang-16",
+            cxx: "clang++-16",
+            clang_version: 16,
+            installed_clang_version: 14
+          }
+
+        - {
+            name: "Ubuntu Clang-17 Debug",
+            os: ubuntu-latest,
+            build_type: "Debug",
+            cc: "clang-17",
+            cxx: "clang++-17",
+            clang_version: 17,
+            installed_clang_version: 14
+          }
+
+        - {
+            name: "Ubuntu Clang-17 Sanitizer",
+            os: ubuntu-latest,
+            build_type: "Release",
+            cc: "clang-17",
+            cxx: "clang++-17",
+            clang_version: 17,
+            installed_clang_version: 14
+          }
+
+        - {
+            name: "Ubuntu Clang-18 Debug",
+            os: ubuntu-latest,
+            build_type: "Debug",
+            cc: "clang-18",
+            cxx: "clang++-18",
+            clang_version: 18,
+            installed_clang_version: 14
+          }
+
+        - {
+            name: "Ubuntu GCC",
+            os: ubuntu-latest,
+            build_type: "Release",
+            cc: "gcc-13",
+            cxx: "g++-13",
+            clang_version: 18,
+            installed_clang_version: 14
+          }
+
+        # Clang doesn't have good enough C++20 support to compile this library
+        # yet.
+        #- {
+        #    name: "macOS Latest Clang",
+        #    artifact: "macOS.tar.xz",
+        #    os: macos-latest,
+        #    build_type: "Release",
+        #    cc: "clang",
+        #    cxx: "clang++",
+        #  }
 
     steps:
       - uses: actions/checkout@v3

diff --git a/README.md b/README.md
@@ -56,7 +56,7 @@ check out which compiler versions are used by the
 |------------|---------|
 | **Clang:** | 16 and up |
 | **GCC**:   | 13 and up |
-| **MSVC**:   | 17.4.2 (not [newer versions](https://github.com/chromium/subspace/issues/267)) |
+| **MSVC**:   | VS2022 17.8.1 (Build 17.8.34316.72) and up |
 
 We attempt to work around bugs when reasonable, to widen compiler version
 support. See [compiler_bugs.h](sus/macros/__private/compiler_bugs.h) for